> On May 20, 2016, 9:41 a.m., Kai Uwe Broulik wrote: > > src/plasma/theme.cpp, line 199 > > <https://git.reviewboard.kde.org/r/127975/diff/1/?file=465281#file465281line199> > > > > Can you add an enum or re-use QIcon::State to avoid a boolean trap, > > same below > > Marco Martin wrote: > i was thinking about it, but decided against exposing a state enum.. > i can use it internally in this private method tough
tough, if i do that, then i would want to expose the state enum in Plasma::Svg as well instead of the selected bool, but i'm not so sure i want to do that - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127975/#review95646 ----------------------------------------------------------- On May 20, 2016, 9:28 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127975/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 9:28 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Like KIconloader, support a Selected state, in IconItem, as in all generic > svgs/framesvg > it replaces the text color with HighlightedText and the background color with > HighlightColor > > > Diffs > ----- > > src/declarativeimports/core/framesvgitem.h 335a9b4 > src/declarativeimports/core/framesvgitem.cpp 1bde3d2 > src/declarativeimports/core/iconitem.h 38a9c7a > src/declarativeimports/core/iconitem.cpp 12008f8 > src/plasma/private/svg_p.h 6f1efc2 > src/plasma/private/theme_p.h 945fcef > src/plasma/private/theme_p.cpp 99e865b > src/plasma/svg.h 3a4ca1d > src/plasma/svg.cpp 507ed75 > src/plasma/theme.cpp 3b7b371 > tests/selected_svg.qml e36924f > > Diff: https://git.reviewboard.kde.org/r/127975/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > showing a framesvg, a SvgItem and an IconItem > > https://git.reviewboard.kde.org/media/uploaded/files/2016/05/20/27777434-baf4-45d2-9f26-71b4b857502d__dadel4.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
