----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95419 -----------------------------------------------------------
Fix it, then Ship it! logic is fine, but should not add public symbols for this completely internal function src/plasma/corona.h (line 363) <https://git.reviewboard.kde.org/r/127850/#comment64692> move in dpointer src/plasma/corona.h (line 364) <https://git.reviewboard.kde.org/r/127850/#comment64691> no private functions in exported classes, ever this should be just a lambda, is used exactly once in a single connect - Marco Martin On May 11, 2016, 11:20 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127850/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 11:20 p.m.) > > > Review request for KDE Frameworks, Plasma and David Rosca. > > > Bugs: 60777 > http://bugs.kde.org/show_bug.cgi?id=60777 > > > Repository: plasma-framework > > > Description > ------- > > Iteration of: https://git.reviewboard.kde.org/r/127848/ > > We either load the existing layout or we load a default one. > > With this, it could be removed from ShellCorona. > > > Diffs > ----- > > src/plasma/corona.h d8f829a > src/plasma/corona.cpp 1784516 > > Diff: https://git.reviewboard.kde.org/r/127850/diff/ > > > Testing > ------- > > Tests pass. > PlasmaShell prints completed once both with and without configuration. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
