broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY The change back to a MouseEventListener broke notification actions because its onClicked handler would fire before the action buttons closing the notification before it had a chance to trigger the action. TEST PLAN I'm not sure we can rely on the order of events but I suppose MEL filters from parent to child? In any way we should avoid the close call after triggering an action. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1578 AFFECTED FILES applets/notifications/package/contents/ui/NotificationItem.qml applets/notifications/package/contents/ui/NotificationPopup.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
