----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review94605 -----------------------------------------------------------
applets/minimizeall/plugin/minimizeall.h (line 49) <https://git.reviewboard.kde.org/r/123653/#comment64308> I'm not convinced that keeping the minimized windows in a list. As explained: this was a problem in KWin, that the behavior was never really defined. The patch adresses some of the problems, but the root problems is still there: What's the expected user behavior? I think that's a huge useability problem with the not well defined state. Before this goes in I want an explicit ack by the useability team. applets/minimizeall/plugin/minimizeall.cpp (lines 58 - 61) <https://git.reviewboard.kde.org/r/123653/#comment64309> maybe Qt::UniqueConnection? applets/minimizeall/plugin/minimizeall.cpp (line 63) <https://git.reviewboard.kde.org/r/123653/#comment64306> categorized logging please applets/minimizeall/plugin/minimizeall.cpp (line 69) <https://git.reviewboard.kde.org/r/123653/#comment64307> careful: detaches the list - Martin Gräßlin On Aug. 25, 2015, 12:41 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123653/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2015, 12:41 p.m.) > > > Review request for Plasma. > > > Bugs: 346837 > http://bugs.kde.org/show_bug.cgi?id=346837 > > > Repository: kdeplasma-addons > > > Description > ------- > > New Minimize Windows Plasmoid > > This plasmoid allows to minimize windows on the current desktop. It does > not mess with the KWindowSystem::showingDesktop flag, just allows to hide > and show windows. > > > Diffs > ----- > > applets/CMakeLists.txt 7ada7ac > applets/minimizeall/CMakeLists.txt PRE-CREATION > applets/minimizeall/Messages.sh PRE-CREATION > applets/minimizeall/package/contents/config/main.xml PRE-CREATION > applets/minimizeall/package/contents/ui/main.qml PRE-CREATION > applets/minimizeall/package/metadata.desktop PRE-CREATION > applets/minimizeall/plugin/minimizeall.h PRE-CREATION > applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION > applets/minimizeall/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123653/diff/ > > > Testing > ------- > > Used it for a while. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
