----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94569 -----------------------------------------------------------
Could you please provide screenshot for comparison? libs/editor/settings/ui/ipv4.ui (line 26) <https://git.reviewboard.kde.org/r/127643/#comment64297> Be aware that qt-desiner adds & to each string, which is something we don't want. libs/editor/settings/ui/ipv4.ui (line 95) <https://git.reviewboard.kde.org/r/127643/#comment64298> Same here. libs/editor/settings/ui/ipv4.ui (line 214) <https://git.reviewboard.kde.org/r/127643/#comment64299> Same here. libs/editor/settings/ui/ipv6.ui (line 42) <https://git.reviewboard.kde.org/r/127643/#comment64300> Same here. libs/editor/settings/ui/ipv6.ui (line 61) <https://git.reviewboard.kde.org/r/127643/#comment64301> Same here. libs/editor/settings/ui/ipv6.ui (line 130) <https://git.reviewboard.kde.org/r/127643/#comment64302> Same here. - Jan Grulich On Dub. 13, 2016, 9:32 dop., Elvis Angelaccio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127643/ > ----------------------------------------------------------- > > (Updated Dub. 13, 2016, 9:32 dop.) > > > Review request for Plasma and Jan Grulich. > > > Repository: plasma-nm > > > Description > ------- > > The labels in the IPv4/IPv6 tabs (dialogs) are currently right-aligned. This > violates the following HIG: > https://techbase.kde.org/Projects/Usability/HIG/Alignment#Labels > > It is also not consistent with the left-aligned labels in e.g. the Wi-Fi tab. > > This patch right-aligns them while keeping the grid layout. An alternative > could be to drop the grid layout and switch to a form layout, which > automatically wuold make the labels left-aligned. > > > Diffs > ----- > > libs/editor/settings/ui/ipv4.ui de574bd > libs/editor/settings/ui/ipv6.ui 9f08cdc > > Diff: https://git.reviewboard.kde.org/r/127643/diff/ > > > Testing > ------- > > > Thanks, > > Elvis Angelaccio > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
