----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-pa Description ------- Virtual streams appear when virtual devices are defined in PulseAudio configuration (eg: combined output for classic analog and HDMI) Those virtual streams aren't properly shown in both the KCM and the applet, producing ghost entries. Screens attached. I added a new property to the Stream object to identify if a stream is real or not. Then, a proxy model takes care of the filtering in the KCM and the applet. For now, only real devices are shown. But we could add a combobox later, at least in the KCM, to be able to display Virtual, Real or both kind of streams. (like pavucontrol) PS : Other review requests are coming (sink selection for streams) but needs some rebasing with David Rosca's latest patches. Diffs ----- applet/contents/ui/main.qml cbe63ced145cd6e755511d025df84a536976eac4 src/kcm/package/contents/ui/StreamView.qml b08c87a2452cadd13bae5b0b94b57c3d8f531b3b src/kcm/package/contents/ui/main.qml 3360201dd8e2a4b5ab03c82c94e5c79d8af9ea4c src/pulseaudio.h 9fc9656e84ee4761d9e8dd9d2a7b8c9d0af9e517 src/pulseaudio.cpp 14887849a04ff2fb3ded5d0d5e60ec3ce4c40745 src/qml/plugin.cpp 5743253f9a7b8283d2bcbeeb081d0706ba4c7b12 src/stream.h b5e09ebaaa0b812f3db81e269671640c783e7c87 src/stream.cpp d8f390805e96bbc2dc69ca02520c049b2ca0a4b6 Diff: https://git.reviewboard.kde.org/r/127540/diff/ Testing ------- File Attachments ---------------- KCM https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/fd74b564-2e56-45e2-88b9-6bf526f98311__Screenshot_20160331_225655.png Applet https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/44b3c277-ee01-4dbf-99f7-dc27edc592e9__Screenshot_20160331_225554.png Thanks, Yoann Laissus
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
