----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/#review91521 -----------------------------------------------------------
>Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip >animation transition between item to decrease it permormance Why does QPropertyAnimation decrease in performance after suspend/restore? Other than the KWindowSystem change I don't see what this is going to alter. You're removing a QPropertyAnimation when it's unused, which won't make a difference as it'll be unused anyway. src/declarativeimports/core/tooltipdialog.cpp (line 179) <https://git.reviewboard.kde.org/r/126870/#comment62531> You now have a a boolean and a potential null pointer both indicating the same thing. Data duplication is generally bad. - David Edmundson On Jan. 24, 2016, 2:08 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126870/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2016, 2:08 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Bugs: 354353 > http://bugs.kde.org/show_bug.cgi?id=354353 > > > Repository: plasma-framework > > > Description > ------- > > Continous usage, read as suspend/resume/use and so on, cause *cool* tooltip > animation transition between item to decrease it permormance and looks quite > ugly. If add new panel animation is *cool* as is. The perfermonce decrease > can be cause due to swap use, or QPropertyAnimation issue, however we (you > KDE defs and i *like a user*) wants plasmashell and it's components (like > panel) to works *forever* > > > Diffs > ----- > > src/declarativeimports/core/tooltip.cpp a5e223b > src/declarativeimports/core/tooltipdialog.h 2ea8af9 > src/declarativeimports/core/tooltipdialog.cpp 6c3712e > > Diff: https://git.reviewboard.kde.org/r/126870/diff/ > > > Testing > ------- > > Workaround is quite simple: > Animation is refreshed as is, pointer hasn't same lifetime as panel > + Animation is disabled if compositing is not active > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
