> On Jan. 21, 2016, 4 p.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 102 > > <https://git.reviewboard.kde.org/r/126837/diff/1/?file=435073#file435073line102> > > > > Please use the active property of Loader rather than setting the source > > in various places.
various places? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126837/#review91421 ----------------------------------------------------------- On Jan. 21, 2016, 3:04 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126837/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 3:04 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > load the lockscreen wallpaper immediately and don't bother to load the actual > ui. > after it's done (we get a frameswapped) load the rest of the ui in a loader. > this will end up in the lockscreen loading actually slower in absolute times, > but in the *perception* it will look like radically faster. > > > Diffs > ----- > > lookandfeel/contents/lockscreen/LockScreen.qml 7e28242 > lookandfeel/contents/lockscreen/LockScreenUi.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126837/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
