----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126802/#review91331 -----------------------------------------------------------
desktoppackage/contents/configuration/AppletConfiguration.qml (line 168) <https://git.reviewboard.kde.org/r/126802/#comment62429> don't set width in a child of a Layout the layout will be altering this property so this gets overriden. We only want to set the implicitWidth (also if you set implicitWidth to width in a layout you get an effective binding loop, but one that doesn't print a warning) - David Edmundson On Jan. 18, 2016, 7:23 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126802/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 7:23 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Fixes issue where the contents rectangle may be smaller than the ScrollView's > width. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a > > Diff: https://git.reviewboard.kde.org/r/126802/diff/ > > > Testing > ------- > > Issue fixed (the issue doesn't occur for every config dialog). > To be honest, it fixes binding loop on `width` in our code, but also brings > binding loop on `value` in Qt ScrollView.qml. But it still fixes the issue. > > > File Attachments > ---------------- > > before.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/4d06a54a-ac6c-45dc-8c32-53415e8b35d5__before.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
