----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126778/#review91209 -----------------------------------------------------------
Ship it! Ship It! - Eike Hein On Jan. 17, 2016, 4 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126778/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2016, 4 p.m.) > > > Review request for Plasma. > > > Bugs: 358039 > http://bugs.kde.org/show_bug.cgi?id=358039 > > > Repository: plasma-framework > > > Description > ------- > > When debugging the linked bug, it looks like for item geometry change eg. > from 0x0 to 100x100, geometryChanged may be called twice, first with 100x0 > and then finally with 100x100. > This was not issue before, because we used timer to call > compactRepresentationCheck. This changes compactRepresentationCheck to earyl > return also with just one part of item size is zero. > > Fix regression from 344dbeb938 > > > Diffs > ----- > > src/plasmaquick/appletquickitem.cpp ec2ed24 > > Diff: https://git.reviewboard.kde.org/r/126778/diff/ > > > Testing > ------- > > Fixes the bug. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
