----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126652/#review90694 -----------------------------------------------------------
On the other hand, given we don't have any UI config for this property... perhaps if we add an UI it should default to a minimum of 10ms (still less than 1 frame) and call it a day. System Tray checks for duration > 0 for the PulseAnimation and PageStack has the animated property bound to duration > 0 - Kai Uwe Broulik On Jan. 6, 2016, 12:39 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126652/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2016, 12:39 nachm.) > > > Review request for Plasma. > > > Bugs: 357352 > http://bugs.kde.org/show_bug.cgi?id=357352 > > > Repository: plasma-framework > > > Description > ------- > > Animators do not reliably fire with a duration of 0 as can be seen in the > linked bug report. > > Upstream bug report: https://bugreports.qt.io/browse/QTBUG-39766 > > > Diffs > ----- > > src/declarativeimports/core/units.cpp 1798727 > src/declarativeimports/plasmacomponents/qml/PageStack.qml cdb2a49 > > Diff: https://git.reviewboard.kde.org/r/126652/diff/ > > > Testing > ------- > > This fixes Widget Explorer and System Tray for me. > > Yet another reason not to divide long/shortDuration by arbitrary values. :) > > Also I don't know if there are things that check for an animation duration to > disable certain behaviors. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
