----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126567/#review90314 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Dec. 29, 2015, 10:04 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126567/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 10:04 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Even when flat we should indicate that a ToolButton has active focus. This > makes keyboard navigation much less awkward to use. > > Unfortunately activeFocus stays there even if I click another button (and we > probably don't want activeFocusOnPress by default or else we always end up > with one strange highlighted ToolButton, ooohh QML and keyboards) > > > Diffs > ----- > > src/declarativeimports/plasmastyle/ToolButtonStyle.qml c9502e7 > > Diff: https://git.reviewboard.kde.org/r/126567/diff/ > > > Testing > ------- > > I can tab through plasma-nm and mediacontroller and actually see where I'm > going > > > File Attachments > ---------------- > > Media Controller focus > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/29/48804e09-f3c3-42b0-8e4b-a12ff9b9c2ed__Screenshot_20151229_225847.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
