----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review90189 -----------------------------------------------------------
src/declarativeimports/core/iconitem.cpp (line 405) <https://git.reviewboard.kde.org/r/122859/#comment61752> huh? that just reloads the current image whenever visibility gets toggled. 1) that's wrong since eike's patch. loadPixmap is deffered till a polish event before 2) how does that fix anything? - David Edmundson On Dec. 28, 2015, 12:17 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122859/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2015, 12:17 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > We have a lot of reusable singletons that are just hidden when unneeded > (tooltip, osd). IconItem, however, will always fade from the previous state, > even if the previous action happened minutes ago. > > This patch makes it track its visibility and skip the fade-and-wait dance > when it just became visible. It also removes a visible false call in the > tooltip which I didn't know what it was for. (With it in place, the IconItem > always becomes visible when moving between tooltip areas, breaking the > animation altogether). > > @Eike: Could you check whether this makes it more viable for Kicker? > > > Diffs > ----- > > src/declarativeimports/core/iconitem.h 528f57c > src/declarativeimports/core/iconitem.cpp 1e8260e > src/declarativeimports/core/tooltip.cpp a5e223b > > Diff: https://git.reviewboard.kde.org/r/122859/diff/ > > > Testing > ------- > > Moving between tray icons - icon fades, moving reaaaally rapidly causes it > not to load any icon until you halt (dunno if that happened before but > doesn't seem too bad) > Hovering tray icon, leaving, waiting, hovering another one - icon does not > fade, is there right away > Notifications also don't fade from the previously issued notification icon > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
