----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126539/ -----------------------------------------------------------
Review request for KDE Frameworks and Plasma. Repository: kwallet-pam Description ------- Coverity strikes again, and notes in CID 1335116 that copying the socket name into a fixed-size buffer here could overflow the buffer. I don't see any reason it would be wrong in all cases, so best to double-check. Submitting for review mostly because I don't use pam_kwallet, otherwise the check is simple enough that I'd feel comfortable committing directly. Note that the len that is already calculated includes the null terminator already. Diffs ----- pam_kwallet.c 345aa03 Diff: https://git.reviewboard.kde.org/r/126539/diff/ Testing ------- Code still compiles. Thanks, Michael Pyne
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
