> On Dec. 27, 2015, 6:24 p.m., David Edmundson wrote: > > drkonqi/main.cpp, line 159 > > <https://git.reviewboard.kde.org/r/126515/diff/2/?file=426276#file426276line159> > > > > and -> or surely? > > > > both in code and comments. > > Kai Uwe Broulik wrote: > The and is correct: > > - I never want to show the dialog or a notification when we're passive. > - I want to show the DrKonqi dialog instead of the KPassivePopup fallback > in case no FDO notification service is available
Ah, I see. We've changed the --passive meaning so that this is no longer opt-in. (you did say that in the updated description, but I didn't parse it properly) So in matrix form: passive|notifications running|action -------|--------|------- Yes | Yes | Show SNI and notification Yes | No | Show SNI and notification No | Yes | Show SNI No | No | Dialog directly ? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90166 ----------------------------------------------------------- On Dec. 27, 2015, 4:11 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126515/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2015, 4:11 p.m.) > > > Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > ------- > > This adds a new "--passive" option to DrKonqi where it will only show a > StatusNotifierItem rather than bringing up the crash dialog right away. > > This can be useful for auto-restarting shell services (like plasmashell, > krunner, kded) to improve the perceived quality of the product. > > On Windows RT, for example, the guidelines even explicitly say "rather just > dump the user on the home screen than telling him something went wrong, so he > can just quickly start the app again instead of being annoyed by an error > message". On iOS you also just get dropped on the home screen. Windows > desktop shows a "Searching for a solution" dialog which was *the* major > annoyance when something crashed, rather than the actual crash. > > Video here: https://www.youtube.com/watch?v=t0ZLs-juYKc > > > Diffs > ----- > > drkonqi/CMakeLists.txt eaeaad4 > drkonqi/main.cpp 7cbaae7 > drkonqi/statusnotifier.h PRE-CREATION > drkonqi/statusnotifier.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126515/diff/ > > > Testing > ------- > > I crashed plasmashell, it restarted so fast that you didn't even have a black > screen inbetween, just the panel restarting. Afterwards I got a SNI which > opened DrKonqi when tapped. > > The SNI disappears after 1 minute because if you didn't bother to look after > it by then, you probably forgot what you did to cause the crash anyway :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
