----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review89948 -----------------------------------------------------------
Ship it! libs/mediacenter/lastfmimagefetcher.cpp (line 172) <https://git.reviewboard.kde.org/r/125993/#comment61653> Use QTimer:singleShot(0, your_slot) instead for better response and remove runSignal. libs/mediacenter/lastfmimagefetcher.cpp (line 176) <https://git.reviewboard.kde.org/r/125993/#comment61655> May be LastFmImageFetcher::setupImageFetcher ? libs/mediacenter/medialibrary.h (line 59) <https://git.reviewboard.kde.org/r/125993/#comment61657> mediaUpdated still sounds wrong, although I am not sure what it should be named. Anyway replace it with more logically correct name. - Ashish Bansal On Dec. 21, 2015, 2:51 p.m., Aditya Dev Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 2:51 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > ------- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList. > > After the image is fetched, gotImage emits the signal mediaUpdated (from > mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel. > > > Diffs > ----- > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/medialibrary.h 45744c1 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > ------- > > Builds 100%. > Works as expected. > > > Thanks, > > Aditya Dev Sharma > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
