----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89900 -----------------------------------------------------------
src/declarativeimports/core/iconitem.cpp (line 396) <https://git.reviewboard.kde.org/r/126466/#comment61623> One of the (albeit extremely flimsy) arguments to a timer is changing both the width and height means we do a loadPixmap twice. Could we move: const int iconSize = Units::roundToIconSize(qMin(boundingRect().size().width(), boundingRect().size().height())); to be a member var outside loadPixmap and only call loadPixmap if that acutally changes? - David Edmundson On Dec. 22, 2015, 3:17 a.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126466/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 3:17 a.m.) > > > Review request for Plasma and David Edmundson. > > > Bugs: 345545 > http://bugs.kde.org/show_bug.cgi?id=345545 > > > Repository: plasma-framework > > > Description > ------- > > This timer seems to exist purely to delay loading the pixmap for the purpose > of "hey, maybe it will work later ..." when it's not actually needed thanks > to QQmlParserStatus. Dropping it brings speed up to par with QIconItem and > fixes various icon flicker around Plasma, in particular in the Task Manager: > When swapping out a launcher delegate for a task delegate, or when swapping > out delegates during virtual desktop switches. > > > Diffs > ----- > > src/declarativeimports/core/iconitem.cpp e260487 > > Diff: https://git.reviewboard.kde.org/r/126466/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
