----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126408/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- If anybody with multi-screen setup could test this, that'd be much appreciated. --- After the 5.5.0/.1 there were quite a few reports about notifications having all sorts of wrong positions and appearing on the wrong screens and combination of these. So I started looking into the code, added a thing here, removed a thing there and after a while it turned into a small refactor of the screen and position handling code. This patch does this: * moves the screen handling code from the import into the applet baseclass, which can access the containment available screen rect and watch for screen changes * fixes the applet config dialog's custom screen position setting which has a bug of always being enabled * consolidates duplicated code in the helper import into functions * ensures that popups have correct positions when on screen that does not start with y=0 (and x=0 in some cases too) Diffs ----- applets/notifications/lib/CMakeLists.txt 6a76c3a applets/notifications/lib/notificationsapplet.h 5b262f1 applets/notifications/lib/notificationsapplet.cpp 891cdb0 applets/notifications/package/contents/ui/Notifications.qml f479a65 applets/notifications/package/contents/ui/configNotifications.qml 95a8e59 applets/notifications/plugin/CMakeLists.txt 2f2239f applets/notifications/plugin/notificationshelper.h 860a2da applets/notifications/plugin/notificationshelper.cpp 15b4479 Diff: https://git.reviewboard.kde.org/r/126408/diff/ Testing ------- I've been testing all sorts of im/possible combinations of multi-screen setups, panel movements on screen, between screens, screen movements etc. Worked as expected in all situations. Einar77 also confirms things are working correctly after a quick test. Thanks, Martin Klapetek
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
