----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ -----------------------------------------------------------
(Updated Dec. 15, 2015, 4:24 p.m.) Review request for KDE Frameworks and Plasma. Changes ------- Address some issues. Repository: kpackage Description ------- Due to KCoreAddons transition from using desktop files to json files, KPackage ended in a weird state where desktop files were allowed to use desktop files but not json. This patch makes sure that manifest.json files are also acceptable. Diffs (updated) ----- autotests/data/testjsonmetadatapackage/contents/ui/main.qml PRE-CREATION autotests/data/testjsonmetadatapackage/metadata.json PRE-CREATION autotests/querytest.cpp 0a2f11a src/kpackage/package.cpp 8416054 src/kpackage/packageloader.cpp 1e1e382 src/kpackage/private/packagejobthread.cpp 444dacc src/kpackage/private/packages.cpp 2f6bbcf Diff: https://git.reviewboard.kde.org/r/126348/diff/ Testing ------- Tests still pass (except for https://build.kde.org/job/kpackage%20master%20stable-kf5-qt5/37/PLATFORM=Linux,compiler=gcc/testReport/, that is not passing in master). Adds a test plugin with a json file in it. Thanks, Aleix Pol Gonzalez
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
