> On Nov. 23, 2015, 11:21 p.m., Thomas Pfeiffer wrote: > > The interaction seems fine, but since it's a user setting, there should not > > be any polkit request. This would confuse users because they don't expect > > to need admin rights to change their own profile picture.
it uses accountsservice so it'll need polkit. whether or not it asks for a password is up to accountsservice - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126151/#review88745 ----------------------------------------------------------- On Nov. 23, 2015, 9:50 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126151/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 9:50 p.m.) > > > Review request for Plasma, KDE Usability and Jonathan Riddell. > > > Bugs: 354001 > http://bugs.kde.org/show_bug.cgi?id=354001 > > > Repository: user-manager > > > Description > ------- > > Including the avatars, that are no longer installed into /usr/share/kdm/icons > but /usr/share/user-manager/avatars. I don't know if there's a FDO location > for these. > > > Diffs > ----- > > src/CMakeLists.txt 7267d24 > src/accountinfo.h c6e70b3 > src/accountinfo.cpp 878f683 > src/avatargallery.h PRE-CREATION > src/avatargallery.cpp PRE-CREATION > src/avatargallery.ui PRE-CREATION > src/pics/Ada Lovelace.png PRE-CREATION > src/pics/Alice in Wonderland.png PRE-CREATION > src/pics/Blackbox.png PRE-CREATION > src/pics/CMakeLists.txt PRE-CREATION > src/pics/Dragon.png PRE-CREATION > src/pics/Grace Hopper.png PRE-CREATION > src/pics/Green.png PRE-CREATION > src/pics/Happy.png PRE-CREATION > src/pics/Kati.png PRE-CREATION > src/pics/Konqui.png PRE-CREATION > src/pics/Leonardo da Vinci.png PRE-CREATION > src/pics/Listening.png PRE-CREATION > src/pics/Logger.png PRE-CREATION > src/pics/Mahatma Gandhi.png PRE-CREATION > src/pics/Mowgli jungle book.png PRE-CREATION > src/pics/Notme.png PRE-CREATION > src/pics/Parley.png PRE-CREATION > src/pics/Rekonqui.png PRE-CREATION > src/pics/TV.png PRE-CREATION > src/pics/User.png PRE-CREATION > src/pics/bomb.png PRE-CREATION > src/pics/sources/Ada Lovelace.svg PRE-CREATION > src/pics/sources/Alice in Wonderland.svg PRE-CREATION > src/pics/sources/Dragon.svg PRE-CREATION > src/pics/sources/Grace Hopper.svg PRE-CREATION > src/pics/sources/Kati.svg PRE-CREATION > src/pics/sources/Konqui.svg PRE-CREATION > src/pics/sources/Leonardo da Vinci.svg PRE-CREATION > src/pics/sources/Logger.svg PRE-CREATION > src/pics/sources/Mahatma Gandhi.svg PRE-CREATION > src/pics/sources/Mowgli jungle book.svg PRE-CREATION > src/pics/sources/Parley.svg PRE-CREATION > src/pics/sources/Rekonqui.svg PRE-CREATION > src/pics/sources/User.svg PRE-CREATION > src/pics/sources/blackbox.svgz PRE-CREATION > src/pics/sources/bomb.svgz PRE-CREATION > src/pics/sources/green.svgz PRE-CREATION > src/pics/sources/happy.svgz PRE-CREATION > src/pics/sources/listening.svgz PRE-CREATION > src/pics/sources/notme.svgz PRE-CREATION > src/pics/sources/tv.svgz PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126151/diff/ > > > Testing > ------- > > Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an > icon, OK. It prompted me three times for Polkit authentication for some > reason but in the end it worked, Kickoff also immediately updated its icon. > > > File Attachments > ---------------- > > New menu option > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png > Avatar gallery > > https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
