> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote: > > The problem with this is that the old applet had the properties widget > > embedded as a page into the applet config dialog. This probably replaces > > the latter, killing the keyboard shortcut page and making it not possible > > to configure a hotkey anymore ...? > > Kai Uwe Broulik wrote: > The old applet also just opened the KPropertiesDialog. > > Eike Hein wrote: > This will still make it hard for users to access config UI they might > have come to rely on (shortcuts) so it's a regression vs. the last stable > release. This needs to be addressed somehow, reverting to Plasma 4 behavior > is a bit of a stretch IMHO. > > Kai Uwe Broulik wrote: > Alternatively we could keep the (empty) settings dialog as is and add > another context menu option for the icon settings, like we do with a couple > of applets that can spawn a KCM. > > Marco Martin wrote: > yeah, a second context menu item would be good in this case i think > > Kai Uwe Broulik wrote: > Okay. > > One thing I noticed is that when I edit eg. Kate and apply in the dialog, > it adds this Kate to the "open with" actions but never removes them again and > now I have 20 Kate entries there :( Any idea how to prevent this?
perhaps when editing an icon that is installed globally, it then creates a copy in the home, and then disaster ensues? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126149/#review88741 ----------------------------------------------------------- On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126149/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 8:54 p.m.) > > > Review request for Plasma. > > > Bugs: ? > https://bugs.kde.org/show_bug.cgi?id=? > > > Repository: plasma-workspace > > > Description > ------- > > This brings back the KPropertiesDialog to modify an icon's appearance. This > has been requested at multiple occasions. This has been adapted from the > Plasma 4 icon code. > > > Diffs > ----- > > applets/icon/package/contents/ui/main.qml 9286b94 > applets/icon/plugin/icon_p.h dd7963c > applets/icon/plugin/icon_p.cpp e086870 > > Diff: https://git.reviewboard.kde.org/r/126149/diff/ > > > Testing > ------- > > Dropped a file from my home onto the desktop -> dialog from the actual file, > allowing to rename it. The applet reflected the changes. > > Dropped an application from kickoff to the desktop -> dialog from a copy of > the desktop file, allowing to change its icon and description. The applet > reflected the changes. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
