----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125734/#review87201 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On Oct. 21, 2015, 8:37 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125734/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 8:37 a.m.) > > > Review request for Plasma, Kai Uwe Broulik and Daniel Vrátil. > > > Bugs: 344651 > http://bugs.kde.org/show_bug.cgi?id=344651 > > > Repository: kscreen > > > Description > ------- > > When using threaded rendering loop [1] systemsettings crashed when > clicking the back button. This crash is caused inside the shader effect > used by the OpacityMask. > QtQuick informed us also that something is wrong: > "QSGDefaultLayer::bind: ShaderEffectSource: 'recursive' must be set to true > when rendering recursively." > > The actual problem is that orientationPanelContainer and the OpacityMask > are children to the monitor item causing recursion. By making them > siblings to the orientationPanelContainer the problem is resolved. The > error message from QtQuick is no longer shown and systemsettings doesn't > crash any more. > > BUG: 344651 > FIXED-IN: 5.4.3 > > [1] QSG_RENDER_LOOP=threaded systemsettings5 > > > Diffs > ----- > > kcm/qml/Output.qml 7bcaf39174a748a203eab5a420cb57c3639d0024 > > Diff: https://git.reviewboard.kde.org/r/125734/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
