> On Sept. 17, 2015, 1:07 p.m., Marco Martin wrote:
> > updates?
> > regardless if screenshots end up being used in the widget explorer applets 
> > or not, I would add the possibility in order to ghns plasmoids to provide 
> > one
> 
> andreas kainz wrote:
>     Yes please.
>     
>     As I wrote in another reviewrequest I added yesterday 3 applet "icons" 
> ordinary icons are located in kde:breeze /icons/... but I can move them also 
> to the plasma applet folder. please let me know where you want to have the 
> screenshots and the icons. now the icons are included into the index.theme 
> file so when you use the "right" icon name applets-analog-clock 
> (applets-widget folder name).
>     
>     As Icons are in kde:breeze I would prefere to have them there. Than I can 
> also provide different 256px icons for breeze, breeze-dark and oxygen (when I 
> would like) but I don't know how it would work with different form factors 
> (do the different form fators have really the same app-name). and for GHNS 
> the screenshots should be shipped with the package.
>     
>     Please let me know what you want Marko and I will prepare it. I'm open 
> for everything. Also for making the icons if needed.

i think should be tried in order:

* png screenshot in-plasmoid

* icon in-pasmoid

* system icon

then default plasmoids would have only the system icon, the screenshot or the 
bundled icon just for gethotnewstuff ones, that can't have a system global icon


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125134/#review85570
-----------------------------------------------------------


On Sept. 17, 2015, 2:01 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125134/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma and andreas kainz.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> As suggested by the VDG, add the possibility to have screenshots for 
> plasmoids.
> the widget explorer will be modified as well to show the screenshots in the 
> applet list when available
> 
> 
> Diffs
> -----
> 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp 99e9add 
>   components/shellprivate/widgetexplorer/plasmaappletitemmodel_p.h f9cc89f 
> 
> Diff: https://git.reviewboard.kde.org/r/125134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to