----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124838/#review84091 -----------------------------------------------------------
Ship it! Assuming you fixed the compile errors... - Martin Gräßlin On Aug. 20, 2015, 4:29 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124838/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 4:29 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > QProcess::startDetached doesn't work on shell scripts, presumably > because it tries to daemonize them. > > Porting to QProcess seems to fix this. As KSMServer stays around forever > this shouldn't result in any behavioural change. > > > Diffs > ----- > > ksmserver/startup.cpp bd80417b25325214199a1cc109f6ea2b2a24ce98 > > Diff: https://git.reviewboard.kde.org/r/124838/diff/ > > > Testing > ------- > > added some shell scripts with > #/bin/sh > echo hello > /tmp/hello > > was greeted pleasantly. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
