----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ -----------------------------------------------------------
(Updated Aug. 17, 2015, 12:50 p.m.) Review request for Plasma. Repository: plasma-desktop Description (updated) ------- Prevent users from moving the panel off the monitor, and prevent users from moving a panel with center alignment to the left (right) and then pull one of the right (left) sliders to the right (left). Because the left and right sliders are coupled, this would make the left (right) sliders to go off the monitor. Also fix that the left (right) sliders cannot be moved over the middle. (In fact they can by using the offset slider, but as soon as on of the left (right) handles are dragged, it sets the position back to the middle). I really don't know the reason for this behavior, and everything works fine (or even better) without it. Does someone know whether this is needed and why? Also delete the default values for min/maxPosition in the SliderHandle, as every handle sets its own min/maxPositions now. And should I add such checks also to panelview.cpp to prevent loading an invalid panel position/size from the config? (Though this should only happen when a user changes the config manually) There are some checks, but not everything is checked.. Diffs ----- desktoppackage/contents/configuration/panelconfiguration/Ruler.qml a31feb40598ba24a107f41ff3b3f823afaa89da6 desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml 3480ce65a961d498055b3952d2d57b4f5d881a9a Diff: https://git.reviewboard.kde.org/r/124786/diff/ Testing ------- I know no way to set an invalid position/size as I could before. It works for horizontal and vertical panels. Thanks, David Kahles
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
