> On July 30, 2015, 6:42 p.m., Mark Gaiser wrote: > > ksmserver/startup.cpp, lines 504-518 > > <https://git.reviewboard.kde.org/r/124534/diff/1/?file=388761#file388761line504> > > > > You're mixing coding styles here. This looks different (more use of > > spaces) then the above chunk. Perhaps run AStyle with kf5 settings over > > this?
The rest of the file doesn't follow the kf5 coding style either. This is plasma-workspace, I don't know if there's a coding style in place, actually. > On July 30, 2015, 6:42 p.m., Mark Gaiser wrote: > > ksmserver/startup.cpp, lines 463-502 > > <https://git.reviewboard.kde.org/r/124534/diff/1/?file=388761#file388761line463> > > > > This chunk seems to be very self contained and not even running the > > autostart. It's merely copying kde 4.x.x files to the new 5.x.x place. > > > > Perhaps move it to a function of it's own. "migrateKde4Autostart()" or > > something alike? I want to share the dest folder, but indeed, this can be passed as argument. I'll do that. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124534/#review83190 ----------------------------------------------------------- On July 30, 2015, 12:48 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124534/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 12:48 p.m.) > > > Review request for Plasma and Vishesh Handa. > > > Repository: plasma-workspace > > > Description > ------- > > Commit f913e251fe6 removed this, due to a porting bug: both klauncher > (XDG autostart using .desktop files) and ksmserver (kde-specific scripts) > were ported to look at the same directory (~/.config/autostart), > leading to double autostart. The right fix, however, is to use > a different directory for scripts, I called it ~/.config/autostart-scripts. > > BUG: 338242 > > > Diffs > ----- > > ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e > ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 > > Diff: https://git.reviewboard.kde.org/r/124534/diff/ > > > Testing > ------- > > Logged out and back in many times :) > > My autostart folder got copied correctly, including symlinks > > > Thanks, > > David Faure > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
