----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124317/#review82304 -----------------------------------------------------------
Ship it! ksplash/ksplashqml/main.cpp (line 93) <https://git.reviewboard.kde.org/r/124317/#comment56672> Given it's closed only when !test && !nofork, I guess the same condition could be reused here? Saves a bool. - Martin Klapetek On July 10, 2015, 10:12 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124317/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 10:12 a.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > On Wayland no window is created with BypassWindowManagerHint. On > platforms != X11 it's better to just set it as fullscreen. This has > the disadvantage that we cannot ensure that the splash stays top of > stack. Might need support from e.g. Wayland compositor. > > [ksplashqml] Delay closing stdin, stdout till app is constructed > > During app startup eglInitialize on Wayland dead locks if the channels > are closed. So delay till app is constructed. > > > Diffs > ----- > > ksplash/ksplashqml/main.cpp 8ab07c66a4efcec2e027182ff4afd5b28c8fcd71 > ksplash/ksplashqml/splashwindow.cpp > b67ec74ab91d6739a8a7bad64d8cb693393547c9 > > Diff: https://git.reviewboard.kde.org/r/124317/diff/ > > > Testing > ------- > > starting a plasma/wayland session now shows a splash screen. Remind me to > live demo that to you during Monday hangout. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
