-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123502/
-----------------------------------------------------------
(Updated April 26, 2015, 5:24 nachm.)
Review request for Plasma and Martin Klapetek.
Changes
-------
Rebased to current master
Bugs: 346673
https://bugs.kde.org/show_bug.cgi?id=346673
Repository: plasma-workspace
Description
-------
DataSource sources is a QStringList property which means changes within cannot
be tracked causing all the job delegates to be destroyed and re-created when
sourcesChanged it emitted. This is pretty wasteful but also causes the delegate
to lose their sate (eg. details expanded).
Diffs (updated)
-----
applets/notifications/package/contents/ui/JobDelegate.qml 709b7fd
applets/notifications/package/contents/ui/Jobs.qml 6ecf366
Diff: https://git.reviewboard.kde.org/r/123502/diff/
Testing
-------
Adding, removing and pausing jobs works as expected, when a job appears or
disappears the other delegates keep their state.
The only slight imperfection is now that the indeterminate state of multiple
jobs is no longer move in sync because the items are no longer created at the
same time.
Thanks,
Kai Uwe Broulik
_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel
