----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123294/#review78671 -----------------------------------------------------------
AuthDialog.cpp (lines 320 - 321) <https://git.reviewboard.kde.org/r/123294/#comment53839> one event cycle might not be sufficient to figure out whether it's the active window. And honestly I have no idea how one could get the information whether the window manager processed it in a reliable way. What might be the most reliable is to wait for the window being added to KWindowSystem::stackingOrder (there's a changed signal). It would give at least the hint that the window manager processed the window being shown. - Martin Gräßlin On April 8, 2015, 3:16 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123294/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 3:16 p.m.) > > > Review request for Plasma. > > > Repository: polkit-kde-agent-1 > > > Description > ------- > > KWindowSystem::activeWindow result is cached, we need to process an > event loop for it to update. > > > Diffs > ----- > > AuthDialog.h 561c6a0 > AuthDialog.cpp 16ee64d > > Diff: https://git.reviewboard.kde.org/r/123294/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
