----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123284/#review78634 -----------------------------------------------------------
Ship it! Sounds good. Bye bye fancy Xcb code. Same goes for oxygen I guess :) - Hugo Pereira Da Costa On April 7, 2015, 3:31 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123284/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 3:31 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > Breeze checks if shadows are supported by checking for a property on the > root window. This is set by kwin at some point after startup. > > This leaves a gap for apps/plasmashell to start, determine shadows are > not supported and then never render them for the lifespan of that app. > > It also can't handle window managers being replaced. > > I spoke to Martin Grasslin who suggested just enabling shadows regardless, > it's not a lot of overhead to load one set of pixmaps even if we don't end up > using it. The alternative is waking up every app every time the root windows > prop changes, which is arguably worse longterm. > > > Diffs > ----- > > kstyle/breezeshadowhelper.h d1be0dc > kstyle/breezeshadowhelper.cpp 2475076 > > Diff: https://git.reviewboard.kde.org/r/123284/diff/ > > > Testing > ------- > > Logged out and logged back in a lot, plasma always got shadows. Same for > session restored apps. > > started dolphin under openbox, switched to kwin, shadows \o/ > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
