----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122209/#review77607 -----------------------------------------------------------
ksmserver/CMakeLists.txt <https://git.reviewboard.kde.org/r/122209/#comment53298> AFAIU the if is not needed. The tests should be marked with "ecm_mark_as_test" which will not build them if BUILD_TESTING is disabled. - Martin Gräßlin On March 17, 2015, 12:18 a.m., Andreas Sturmlechner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122209/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 12:18 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Qt5Test should not be mandatory. > > > Diffs > ----- > > CMakeLists.txt 907c00836531db511a91860993a54acd89720055 > ksmserver/CMakeLists.txt c0543e29904b663b3600832e5e8855b3927ee3ce > ksmserver/screenlocker/greeter/CMakeLists.txt > d502cb82516e85a76685d7e3d7106a41dcf0cfff > > Diff: https://git.reviewboard.kde.org/r/122209/diff/ > > > Testing > ------- > > Built with (all successful) and without tests. > > > Thanks, > > Andreas Sturmlechner > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
