> On März 10, 2015, 9:23 nachm., Marco Martin wrote: > > applets/kickoff/package/contents/ui/configGeneral.qml, line 63 > > <https://git.reviewboard.kde.org/r/122894/diff/1/?file=354051#file354051line63> > > > > this looks a bit hackish, sure is visually really necessary?
In a widget world with the menu attached to the button it stays in its pressed state until the menu closes. Since we cannot change the state to pressed from the outside, I use the checked property to provide some kind of feedback. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122894/#review77271 ----------------------------------------------------------- On März 10, 2015, 8:55 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122894/ > ----------------------------------------------------------- > > (Updated März 10, 2015, 8:55 nachm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This restores the functionality from the 4.x times. The button uses the same > style used in various places, such as lockscreen and display manager, it has > a "Choose" action and a, previously missing, convenient "Clear" action. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/configGeneral.qml 0b6ec33 > > Diff: https://git.reviewboard.kde.org/r/122894/diff/ > > > Testing > ------- > > Choosing an icon works, applying changes the icon, and reset resets it. Is > there a way to set a config back to its defaults? > > > File Attachments > ---------------- > > Config in action > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/10/6854d475-e5d1-49a0-b335-19a9028a704c__kickofficondialog.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
