----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122256/#review74751 -----------------------------------------------------------
Ship it! I think we should investigate the usefullness of the pin further, but for now it is an improvement. So, go for it :) - Bjoern Balazs On Jan. 25, 2015, 11:13 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122256/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 11:13 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > The current pin has poor hover and no pressed feedback making it quite > difficult to use. Often I click it but the color animation takes too long and > I click again. This allows us also to provide a tooltip (suggestions on > wording?) explaining what this button does since its effects aren't obvious > immediately. > > > Diffs > ----- > > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml abbb970 > > Diff: https://git.reviewboard.kde.org/r/122256/diff/ > > > Testing > ------- > > Interacting with the pin is now straight-forward and consistent with the > other interactive controls. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/25/df6ab162-9053-4266-8129-a4ad3410a7ce__pinbefore1.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/01/25/6c299b2a-8445-4f69-87b9-c3161a9ec6ab__pinafter1.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
