----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122233/#review74654 -----------------------------------------------------------
Ship it! one nitpick, otherwise +1 src/kded/kdedactions.cpp <https://git.reviewboard.kde.org/r/122233/#comment51738> since isConfiguration itself is bool, act->setProperty("isConfigurationAction", isConfiguration); - Bhushan Shah On Jan. 24, 2015, 4:51 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122233/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2015, 4:51 p.m.) > > > Review request for Plasma and Lukáš Tinkl. > > > Repository: kcm-touchpad > > > Description > ------- > > isConfigurationAction need to be set to true if QAction is only for > configuration purpose, otherwise it will unregister from kglobalaccel daemon > when destroyed. > > > Diffs > ----- > > src/kcm/touchpadconfig.cpp 75494c2 > src/kded/kded.cpp 52389b6 > src/kded/kdedactions.h 200e466 > src/kded/kdedactions.cpp d2abc9c > > Diff: https://git.reviewboard.kde.org/r/122233/diff/ > > > Testing > ------- > > After close shortcut configuration dialog and kcm, the global shortcut is > still functional. > > > Thanks, > > Xuetian Weng > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
