----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122192/#review74496 -----------------------------------------------------------
Ship it! Ship It! - Sebastian Kügler On Jan. 21, 2015, 7:37 p.m., Daniel Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122192/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 7:37 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This patch brings back behaviour from KDE4-Kickoff, where the applet's icon > in panel could be changed. > > This patch only adds a config option to set the icon, but no config UI for > users to change it - mostly because there does not seem to be any > ImageChooser component in PlasmaQuick that I could use and I don't feel like > writing one on my own right now :-) > > The reason to bring this back is that distributions might want to customize > the icon like they did in KDE 4 and patching .desktop files is not the nicest > way to do it. Also once we have the ImageChoose QML component, an option can > be added to config UI for users to fully customize it. > > > Diffs > ----- > > applets/kickoff/package/contents/config/main.xml 3a859e8 > applets/kickoff/package/contents/ui/Kickoff.qml 21bf1d5 > > Diff: https://git.reviewboard.kde.org/r/122192/diff/ > > > Testing > ------- > > Opened ~/.config/plasma-org.kde.plasma.desktop-appletrc, added > icon=start-here-kde-fedora to the respective config group, restarted Plasma, > Kickoff now has Fedora logo. > > > Thanks, > > Daniel Vrátil > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
