----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121070/#review70097 -----------------------------------------------------------
Ship it! Another component down, nice! src/declarativeimports/plasmacomponents/qml/styles/BusyIndicatorStyle.qml <https://git.reviewboard.kde.org/r/121070/#comment49059> this ID is unused, removing it will save a (super super tiny) amount of overhead. - David Edmundson On Nov. 8, 2014, 3:48 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121070/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 3:48 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > As per Plasma 5.2 Kanboard, straight forward patch moving the style stuff > into a separate file. > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml 61197ea > src/declarativeimports/plasmacomponents/qml/styles/BusyIndicatorStyle.qml > PRE-CREATION > tests/components/busyindicator.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121070/diff/ > > > Testing > ------- > > Works well with the notification plasmoid, simple test inside :) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
