> On Sept. 28, 2014, 11:23 p.m., David Edmundson wrote: > > wallpapers/image/image.cpp, line 563 > > <https://git.reviewboard.kde.org/r/120411/diff/1/?file=315619#file315619line563> > > > > we don't really need the if() > > we know it's a valid pointer as we set it only 2 lines ago.
(plus the frameworks coding style says "KNS3::DownloadDialog *strong" and always braces around if-else) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120411/#review67591 ----------------------------------------------------------- On Sept. 28, 2014, 11:19 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120411/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2014, 11:19 p.m.) > > > Review request for Plasma. > > > Bugs: 336737 > https://bugs.kde.org/show_bug.cgi?id=336737 > > > Repository: plasma-workspace > > > Description > ------- > > Set title on wallpaper kns dialog. BUG:336737 > > > Diffs > ----- > > wallpapers/image/image.cpp 373d8242083db70ed6af10e0861a61e6e8522bf1 > > Diff: https://git.reviewboard.kde.org/r/120411/diff/ > > > Testing > ------- > > The wallpaper kns dialog shows "Download Wallpapers" instead of "Plasma > Add-On Installer" > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
