> On Sept. 16, 2014, 4:01 p.m., Hugo Pereira Da Costa wrote: > > ok, ship it, then :) > > in the meanwhile I'll try compile a more recent Qt5 version (which branch > > do you use ? stable ?) > > and then I'll go debug breeze and oxygen (I'm actually eager to)
"stable" shouldn't be used. The right branch name is "5.4". I think the biggest issues aren't the fault of the style. Fusion is just as bad (if anything worse) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120234/#review66683 ----------------------------------------------------------- On Sept. 16, 2014, 2:33 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120234/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 2:33 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > ------- > > This is the flag that application developers need to set if they want to > support smooth scaling. > > From a QStyle perspective we need to support both having this set and > not set. The demo seems a good place to start testing and fixing. > > With QT_DEVICE_PIXEL_RATIO=2: > Without this flag everything looks blocky but is in the right place. > > With this flag, everything looks super smooth but some layout parts are > screwed. > > > Diffs > ----- > > kstyle/demo/main.cpp ed2f3b4 > > Diff: https://git.reviewboard.kde.org/r/120234/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
