> On Aug. 30, 2014, 12:41 p.m., Martin Yrjölä wrote: > > applets/systemloadviewer/package/contents/ui/ColorSettings.qml, lines 49-50 > > <https://git.reviewboard.kde.org/r/120002/diff/1/?file=308582#file308582line49> > > > > Is anchors the correct way to implement spacing in QML? The HIG states > > in [1] that the sub-options should be indented by using a horizontal spacer > > of SizeType "Minimum". What would be the QML equivalent? > > > > [1] > > https://techbase.kde.org/Projects/Usability/HIG/Form_Label_Alignment#Aligning_Sub-Options
yeah, that's right. > On Aug. 30, 2014, 12:41 p.m., Martin Yrjölä wrote: > > applets/systemloadviewer/package/contents/ui/GeneralSettings.qml, lines > > 74-78 > > <https://git.reviewboard.kde.org/r/120002/diff/1/?file=308583#file308583line74> > > > > Can I get rid of this Item somehow? I'm aiming for approach 1 in the > > checkbox alignment guidelines [1]. If I put the rowSpan in the checkbox > > group's label then the label gets vertically centered in the middle of the > > group. But if I then apply `Layout.alignment: Qt.AlignTop` the labels > > doesn't line up correctly. Same problem on line 91-94. > > > > [1] > > https://techbase.kde.org/Projects/Usability/HIG/Form_Label_Alignment#Checkboxes ah. I can see why that could be an issue. I'll have a play for a few minutes, worst case we keep what we have. > On Aug. 30, 2014, 12:41 p.m., Martin Yrjölä wrote: > > applets/systemloadviewer/package/contents/ui/GeneralSettings.qml, line 154 > > <https://git.reviewboard.kde.org/r/120002/diff/1/?file=308583#file308583line154> > > > > Is the i18n call needed for a single character abbreviation? It needs to be i18n. The chinese abbreviation for "seconds" is unlikely to be "s". however, equally translators aren't going to understand how to translate "s". So we need to tell them what it is, there's a call i18nc where you can give translators a sentence to give them some context. i18nc("Abbreviation for secounds", "s"); - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120002/#review65538 ----------------------------------------------------------- On Aug. 30, 2014, 12:20 p.m., Martin Yrjölä wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120002/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2014, 12:20 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: kdeplasma-addons > > > Description > ------- > > More polish by courtesy of the VDG. > > > Diffs > ----- > > applets/systemloadviewer/package/contents/ui/ColorPicker.qml > 1b3c88233da75b9d001a0159dd4298d41f7d307c > applets/systemloadviewer/package/contents/ui/ColorSettings.qml PRE-CREATION > applets/systemloadviewer/package/contents/ui/GeneralSettings.qml > fd719d5f2afed8c630fd6a1281f6ddda674b60c2 > applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml > 9e101f8fd68602495366c0dc8226927a572e0267 > applets/systemloadviewer/package/contents/config/config.qml > 570cc77ece3ed0bf84d89e45426773954f95d409 > applets/systemloadviewer/package/contents/config/main.xml > 5e38045eb369e029564abf973827eb84534eb9f4 > > Diff: https://git.reviewboard.kde.org/r/120002/diff/ > > > Testing > ------- > > Mostly cosmetic changes, but I tested that the options does still work. > > > File Attachments > ---------------- > > General settings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/7ed9b718-93bd-4936-98dd-7a58b8b51128__2014-08-30-142153_361x169_scrot.png > Color settings with enabled manual color settings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8e2367fd-9f44-4bd2-87fe-df5ffbd746be__2014-08-30-143838_256x304_scrot.png > Color settings with disabled manual color settings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/30/8399a4e1-7fa0-4369-ae30-cadbe455d2bb__2014-08-30-143853_254x304_scrot.png > > > Thanks, > > Martin Yrjölä > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
