> On Aug. 8, 2014, 12:04 p.m., Marco Martin wrote:
> > there is an issue with it that came out only now with neon image that start
> > with a clean environment:
> > default favorites are now completely lost, kickoff starts with an empty list
>
> Ivan Čukić wrote:
> The defaults should be set in the global kickoffrc file. It should be
> imported then (if a local kickoffrc has favourites, the should get loaded
> instead).
>
> Eike Hein wrote:
> Can you define "a local kickoffrc"? If multiple Kickoff instances can't
> have different favourites, it's a bug. Widget configuration is instance-local.
>
> Ivan Čukić wrote:
> As far as I see, kickoff in plasma 1 uses a kickoffrc file where it
> stores its favourites, and they are shared accross different instances of
> kickoff.
>
> We've had a lot of requests to make the favourites unified even accross
> different launchers (that is, I've had a lot of requests to make Kickoff and
> Lancelot favourites shared).
>
> Now we should switch to each instance has its own? If that is the case,
> there is no point in using activity manager for application<->activity
> linking. And the per-activity favorites patch should be reverted.
>
> Ivan Čukić wrote:
> p.s. Also ignore the review for kicker.
>
> Eike Hein wrote:
> This sounds like something we need a proper community-wide solution for
> me. My thinking is:
>
> * Plasma generally allows for multiple instances of the same widget with
> independent config, and breaking down those barriers is sort of a slippery
> slope that makes the system unpredictable for users ("if I change this, will
> it only affect this widget or all of them? I can't be sure").
> * Aside from making it unpredictable, it's also more restrictive - you
> lose the ability to use separate settings if you want them to be separate (in
> this concrete case, e.g. different favorites per monitor).
> * Allowing shared config requires widget authors to do much work work to
> implement things correctly (realtime synchronization).
> * Storing config outside the widget means that downstream customizers
> need to use two different ways to pre-configure widgets (desktop scripting
> for instance-local config, random rc files for other config).
>
> Specifically as far as launchers are concerned, as I mentioned on IRC,
> Marco and I have been talking on and off that we could use some sort of
> launcher framework to fix all the applet-specific interfaces we have right
> now.
>
> For example, Kicker has the application item context menu actions "Add to
> Panel", "Add to Task Manager" and "Add to Desktop". "Add to Task Manager"
> requires finding a Task Manager instance in the same containment and calling
> a function on it, and "Add to Desktop" behaves differently depending on
> whether the screen containment is a Folder instance (it will then all a
> function that creates a symlink) or not (it will then create an Icon applet
> instance, like "Add to Panel" does).
>
> All of this is highly desirable from an UX point of view - users want to
> do all of those - and it works, but it involves some hard-coded plugin
> identities.
>
> Now, if we do store launcher state somewhere central, though, then
> interested clients of that service still need to be able to select a subset
> of launchers to show, though, so that the specific launchers shown can be
> individual per instance.
>
> Eike Hein wrote:
> (Sorry, I meant "community-wide discussion to me".)
Can you start a discussion on plasma-devel?
- Ivan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106448/#review64057
-----------------------------------------------------------
On July 29, 2014, 9:42 a.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/106448/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 9:42 a.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> I think it's time now to get the new kickoff into master so we can polish it
> for KDE 4.10. the qml plasmoid is still using the old model code (though
> slightly adjusted). This could cause issues for the c++ menu launcher
> "simpleapplet"...I'm not using it but actually it doesn't even compile.
> Probably would be better to port it to qml as well...opinions?
>
> The qml code resides in the package dir. It's a pure qml widget with c++
> model extensions...obviously :)
>
> Add to Panel/Desktop is still not supported but overall I think we have
> reached feature parity with kickoff c++
>
> I'm also worried about the upgrade path from kickoff-c++ to kickoff-qml. How
> can we ensure a smooth transition for devs and users?
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/CMakeLists.txt
> e9e288866ecdcfd7aa35c086dfe78d4252748995
> plasma/desktop/applets/kickoff/Messages.sh
> b1fa03bcfd6254de7697a674a37919724a0a0965
> plasma/desktop/applets/kickoff/applet/applet.h
> f3afe734df993a4fad950068143d84f9e25dedc8
> plasma/desktop/applets/kickoff/applet/applet.cpp
> a6f7379e830ea02c702f492eb94bf489d87314e1
> plasma/desktop/applets/kickoff/core/CMakeLists.txt PRE-CREATION
> plasma/desktop/applets/kickoff/core/applicationmodel.h
> f0f8872255956321292151cdd82326cdf88c5508
> plasma/desktop/applets/kickoff/core/applicationmodel.cpp
> 57b6ba524255fc59c2ff5b58a64edc1c7f0f82e2
> plasma/desktop/applets/kickoff/core/favoritesmodel.h
> 8ee3e9a9eb16780131d59b150b50641e5a03a34c
> plasma/desktop/applets/kickoff/core/favoritesmodel.cpp
> 58c2c5de8defe415d64204c795075e16c23e883c
> plasma/desktop/applets/kickoff/core/itemhandlers.h
> ec72cbe51b6e2da604ba6eba96f9e6f3f5935f67
> plasma/desktop/applets/kickoff/core/itemhandlers.cpp
> 4e83c37588af1ebab331082e2eaccb40a0f8155c
> plasma/desktop/applets/kickoff/core/kickoffabstractmodel.cpp
> 7e2e64d22e9e274ffe3d37fdd0ac2c33a622ea3a
> plasma/desktop/applets/kickoff/core/kickoffmodel.cpp
> 8149cac20ce8ab246d8f484ca7567fc6e32d548c
> plasma/desktop/applets/kickoff/core/kickoffplugin.h PRE-CREATION
> plasma/desktop/applets/kickoff/core/kickoffplugin.cpp PRE-CREATION
> plasma/desktop/applets/kickoff/core/kickoffproxymodel.cpp
> f92bca971e0f9fcb644cadab6aa39a3e36291c00
> plasma/desktop/applets/kickoff/core/krunnermodel.h
> 93a8b152a673eb6233727a82eefd70739ffc5a0f
> plasma/desktop/applets/kickoff/core/krunnermodel.cpp
> 452ebbe81311f8e3e95b5eda5fb9217344852d06
> plasma/desktop/applets/kickoff/core/leavemodel.h
> 0676fb9358bdfd5e3cffce7eb3a0ea5e4ff70989
> plasma/desktop/applets/kickoff/core/leavemodel.cpp
> 47559cef7331ac5b37f42ed57c7c9a6668d5d53b
> plasma/desktop/applets/kickoff/core/models.h
> 3332ba9608808b353c32d96c37b84ddd82aabddf
> plasma/desktop/applets/kickoff/core/models.cpp
> c787df6e2f2c7c88ff97c64c7cd7640cce32365b
> plasma/desktop/applets/kickoff/core/qmldir PRE-CREATION
> plasma/desktop/applets/kickoff/core/recentapplications.h
> a0feddca1cebbeb556623216bcc6c5c30e13a2a4
> plasma/desktop/applets/kickoff/core/recentapplications.cpp
> 3e0538958564ae690e41791bdb5af76fa2ca9a8f
> plasma/desktop/applets/kickoff/core/recentlyusedmodel.h
> 841eb2b77aee778a85c76eafa61d38016f6ade58
> plasma/desktop/applets/kickoff/core/recentlyusedmodel.cpp
> 2762d6d63a7b0592a7e87cd99603cc7c418292c5
> plasma/desktop/applets/kickoff/core/systemmodel.h
> 3d7d6e1e6ebb8f3d14f09ff5f2e9c22098f4add2
> plasma/desktop/applets/kickoff/core/systemmodel.cpp
> 11688a10a03a3cdd6ff84bfff65d48bec336afbd
> plasma/desktop/applets/kickoff/core/urlitemlauncher.h
> 26b638fc02f42505e29857b5c18736e6778a580e
> plasma/desktop/applets/kickoff/core/urlitemlauncher.cpp
> 75bbfb5a5c6df837e7e56de501156b2ca12ed6d7
> plasma/desktop/applets/kickoff/package/contents/ui/ApplicationsView.qml
> PRE-CREATION
> plasma/desktop/applets/kickoff/package/contents/ui/Breadcrumb.qml
> PRE-CREATION
> plasma/desktop/applets/kickoff/package/contents/ui/KickoffButton.qml
> PRE-CREATION
> plasma/desktop/applets/kickoff/package/contents/ui/KickoffItem.qml
> PRE-CREATION
> plasma/desktop/applets/kickoff/package/contents/ui/MainView.qml
> PRE-CREATION
> plasma/desktop/applets/kickoff/package/contents/ui/SearchView.qml
> PRE-CREATION
> plasma/desktop/applets/kickoff/package/contents/ui/kickoff.qml PRE-CREATION
> plasma/desktop/applets/kickoff/package/metadata.desktop PRE-CREATION
> plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.h
> PRE-CREATION
> plasma/desktop/applets/kickoff/simpleapplet/contextmenufactory.cpp
> PRE-CREATION
> plasma/desktop/applets/kickoff/simpleapplet/menuview.cpp
> 7d2fb7bd0d92c8dcaa31a87ca3fcd0742310e101
> plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp
> 28fba18a1cddbd9be58991b35dba69fb60e4416c
> plasma/desktop/applets/kickoff/ui/brandingbutton.h
> 698b34e50372dddc3db9425ab2ac639cf90d49b7
> plasma/desktop/applets/kickoff/ui/brandingbutton.cpp
> 5cd8829b8a6cae1e07cbf9bffd3abe77b7f9104e
> plasma/desktop/applets/kickoff/ui/contentareacap.h
> 58b37ec74834eefd969786ec99a5cf25b27baf5c
> plasma/desktop/applets/kickoff/ui/contentareacap.cpp
> 45e0e2052720402451ae00bed05f6bb0598ec0b3
> plasma/desktop/applets/kickoff/ui/contextmenufactory.h
> a4c3017b537aa12369b08f7fffb28addcca6bce4
> plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp
> afa666ac8dfaf6c746d165d7d662fab185af4442
> plasma/desktop/applets/kickoff/ui/flipscrollview.h
> e7eba0939237c686ff1ca6c0d4c5a6c924ff26d6
> plasma/desktop/applets/kickoff/ui/flipscrollview.cpp
> 1d48f5b4562c230db7d8b6d8d578e5a09cd9e2c4
> plasma/desktop/applets/kickoff/ui/itemdelegate.h
> bf79e2cc1f501e7136decfa7cd05ea651b109cf6
> plasma/desktop/applets/kickoff/ui/itemdelegate.cpp
> 3b15dd2e7a6ceaba66e1e7da27a811ea8ec31c2f
> plasma/desktop/applets/kickoff/ui/launcher.h
> 2a234c36d6fe320cc8021d074156ba2299158e4f
> plasma/desktop/applets/kickoff/ui/launcher.cpp
> 4425bcc79daff81f2448d19a75f3feb69dd57543
> plasma/desktop/applets/kickoff/ui/searchbar.h
> 60aa9b4b3faaafd5484a36a819b8ac0ed5683a9a
> plasma/desktop/applets/kickoff/ui/searchbar.cpp
> 1af8fa95e3497e50cba629c2086a9fb381a166ff
> plasma/desktop/applets/kickoff/ui/tabbar.h
> c9281059d35255902fd6d3ed91c5171a44421a51
> plasma/desktop/applets/kickoff/ui/tabbar.cpp
> 43fe16b723ab2010bd02864a911d2d2c8d106821
> plasma/desktop/applets/kickoff/ui/urlitemview.h
> 285227a40b71065a0219c33293c955df3c5c518b
> plasma/desktop/applets/kickoff/ui/urlitemview.cpp
> 892b85be96695d7d71d4494af92dae794cb86d66
> plasma/generic/dataengines/packagekit/CMakeLists.txt PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekit.operations PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekitengine.h PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekitengine.cpp PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekitjob.h PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekitjob.cpp PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekitservice.h PRE-CREATION
> plasma/generic/dataengines/packagekit/packagekitservice.cpp PRE-CREATION
> plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop
> PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/106448/diff/
>
>
> Testing
> -------
>
> not too much, surely have to update this diff a couple of times. But you can
> start dropping comments anyway.
>
>
> Thanks,
>
> Greg T
>
>
_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel
