> On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > >
Because I wasn't very clear. I will also open reviews for every plugin that I have created. I just started with the plasmate's shell. We could discuss about the plugins in their individual reviews or of course we could discuss it here. As you want. :) > On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: How plasmate should look like in the end - plasmate_ui.png > > <https://git.reviewboard.kde.org/r/119411/#fcomment242> > > > > Didn't you have an editor for metadata files? Yes its called Metadata Editor, its in the right. > On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: How plasmate should look like in the end - plasmate_ui.png > > <https://git.reviewboard.kde.org/r/119411/#fcomment243> > > > > Maybe you don't want the console? Yes, we don't want some of the plugins, but I havedn't removed any of them yet. > On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: How plasmate should look like in the end - plasmate_ui.png > > <https://git.reviewboard.kde.org/r/119411/#fcomment244> > > > > Have you integrated plasma documentation there? No I haven't. In the past we used to offer a webview which was loading techbase.kde.org. Which with the port to KDevPlatform we will use it as a plugin. > On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: How plasmate should look like in the end - plasmate_ui.png > > <https://git.reviewboard.kde.org/r/119411/#fcomment245> > > > > Wouldn't it make sense to integrate Package into Project? > > > > What are the differences? Ok, Project is showing to the user the actual name of the dir/file. So for the file main.qml Project will show "main.qml", but Package is showing the semantic name of the files/dirs which is taken from the plasma package. So Package for the file main.qml will show "Main Script File". We wanted to present the files/dirs to the user with their semantic names. This is the reason why I created Package, I couldn't find a way to do that with Project > On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > > File Attachment: How plasmate should look like in the end - plasmate_ui.png > > <https://git.reviewboard.kde.org/r/119411/#fcomment246> > > > > 2 Run menus? > > > > In fact, plasmate probably wants to define its own menus, right? I have fixed the 2 Run Menus. Yes plasmate would like to have its menus.The menus should probably make it easier for the user to "find" the plasma specifc toolviews like the plasmoidviewer toolview. I haven't done any big changes to the menus(comparing it with the KDevPlatform shell) because the actions from the menus would come out from the plugins which I don't have included in this review request. > On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: > > plasmate/app/main.cpp, line 74 > > <https://git.reviewboard.kde.org/r/119411/diff/2/?file=294902#file294902line74> > > > > Patches are welcome. Of course :) This was a personal note in order to fix it later. - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review64004 ----------------------------------------------------------- On Aug. 2, 2014, 1:20 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119411/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2014, 1:20 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > I have separated this task to two reviews, because there are also some > `git mv` in order to have a decent directory structure which I don't have > included in this review for readability. > > Below is the list of commits from which this review has been made. > > ---- > > * use some private members and improve readability > > ---- > * Every project must have a .plasmate file in order to pick the Manager. > > ---- > * Initial commit for porting plasmate to kdevplatform > > We introduce a new class named PlasmateApp which will > show the Startpage and hide it, when it must do it. > > > Diffs > ----- > > plasmate/CMakeLists.txt 1a6ce87 > plasmate/app/main.cpp PRE-CREATION > plasmate/app/plasmateapp.h PRE-CREATION > plasmate/app/plasmateapp.cpp PRE-CREATION > plasmate/app/plasmateextention.h PRE-CREATION > plasmate/app/plasmateextention.cpp PRE-CREATION > plasmate/app/plasmateui.rc PRE-CREATION > plasmate/main.cpp 633c4cc > plasmate/plasmateui.rc 41f6025 > plasmate/startpage.h 4c77e29 > plasmate/startpage.cpp a65a2cc > > Diff: https://git.reviewboard.kde.org/r/119411/diff/ > > > Testing > ------- > > You can also test this review from > > url: > http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git > git: > git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git > branch: r/119411 > > > File Attachments > ---------------- > > How plasmate should look like in the end > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
