> On July 10, 2014, 10:57 a.m., David Edmundson wrote: > >
also convention for private headers seems to be still _p.h even though you're in a folder called private. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119199/#review62060 ----------------------------------------------------------- On July 9, 2014, 3:41 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119199/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 3:41 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Since the tool in davidedmundson/plasmoidloader was discarded, I've been > thinking we need a way to tell how things are run in the plasma shell. The > argument was that we need to run the plasmoids in a containment, so > escentially the only way to get it is doing it within the plasmashell. > > What I did here is to create a small class that keeps track of an object the > changes in the properties and relates them to a point in time. This way we > can see how things change and react to each other. Then, this information is > outputted in a json file to analyze. > > Take this review request as a request for comments, there's many things we > can add there. > > > Diffs > ----- > > src/plasma/private/containment_p.cpp 6a3b09c > src/plasma/private/timetracker.h PRE-CREATION > src/plasma/private/timetracker.cpp PRE-CREATION > src/plasma/applet.h 6effcc7 > src/plasma/containment.h c3907b0 > src/plasma/private/applet_p.cpp 2f680bf > src/plasma/CMakeLists.txt 3801857 > > Diff: https://git.reviewboard.kde.org/r/119199/diff/ > > > Testing > ------- > > Runs fine. > > Here I'm attaching an example that portraits how the pager plasmoid changes > status many times for no apparent reason and how I'm not ever getting the > isUiReady(true). > > > File Attachments > ---------------- > > example > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/09/8e3bb455-9c5e-48fd-8471-f2726e6ed6af__debug-apol.json > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
