> On July 8, 2014, 1:51 p.m., Marco Martin wrote: > > toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml, line 171 > > <https://git.reviewboard.kde.org/r/119179/diff/1/?file=289061#file289061line171> > > > > why *0.8? > > the parent already has the margins size removed iirc? > > Aleix Pol Gonzalez wrote: > Well, because we want to have it filling the space but not all over the > place. It doesn't look well with *1.
it should leave the margins defined by the framesvg, not sureif is correct adding an arbitrary margin.. may be for the border that gets offscreen, bah, let's try it. - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119179/#review61896 ----------------------------------------------------------- On July 8, 2014, 1:47 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119179/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 1:47 p.m.) > > > Review request for Plasma. > > > Bugs: 337055 > https://bugs.kde.org/show_bug.cgi?id=337055 > > > Repository: plasma-desktop > > > Description > ------- > > Instead of using the iconSize, use the toolbox size. > > See bug 337055. > > > Diffs > ----- > > toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml a3b5be4 > > Diff: https://git.reviewboard.kde.org/r/119179/diff/ > > > Testing > ------- > > Changed font size, played around with it a bit. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
