----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119176/#review61887 -----------------------------------------------------------
applets/kickoff/core/kuserproxy.h <https://git.reviewboard.kde.org/r/119176/#comment43093> Follow the convention and use m_tmpFaceIcon? applets/kickoff/core/kuserproxy.cpp <https://git.reviewboard.kde.org/r/119176/#comment43091> Coding Style: Please move the { to the next line applets/kickoff/core/kuserproxy.cpp <https://git.reviewboard.kde.org/r/119176/#comment43092> This is a really minor thing so feel free to ignore me: Could you put the path variable on the LHS or put the path variable on the LHS on line 61. It's currently inconsistent. applets/kickoff/core/kuserproxy.cpp <https://git.reviewboard.kde.org/r/119176/#comment43095> You'll be returning "invalid image". Why not just an empty string? - Vishesh Handa On July 8, 2014, 12:49 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119176/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 12:49 p.m.) > > > Review request for Plasma. > > > Bugs: 336792 > https://bugs.kde.org/show_bug.cgi?id=336792 > > > Repository: plasma-desktop > > > Description > ------- > > Since KUser doesn't provide any change signalling, we're watching both, > /etc/passwd (if it exists) and the face icon path for changes. The > latter is a pretty static thing in KUser, so it's safe to assume it > doesn't change at runtime. > > This makes updating the user's full name and face image from > Personal Settings / Password & User Account update Kickoff's header work > at runtime > > > Diffs > ----- > > applets/kickoff/core/kuserproxy.h ec77217 > applets/kickoff/core/kuserproxy.cpp 713a182 > applets/kickoff/package/contents/ui/Header.qml 75e2d97 > > Diff: https://git.reviewboard.kde.org/r/119176/diff/ > > > Testing > ------- > > Changed user information, watched Kickoff update automatically. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
