----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117374/#review58314 -----------------------------------------------------------
ksysguard/kdedksysguard.cpp <https://git.reviewboard.kde.org/r/117374/#comment40563> compile-time checks would be nicer here. ksysguard/kdedksysguard.cpp <https://git.reviewboard.kde.org/r/117374/#comment40564> compile-time syntax, please ksysguard/kdedksysguard.cpp <https://git.reviewboard.kde.org/r/117374/#comment40565> filterText is always empty here ksysguard/kdedksysguard.cpp <https://git.reviewboard.kde.org/r/117374/#comment40566> filterText is empty here - Sebastian Kügler On May 22, 2014, 2:18 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117374/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 2:18 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This module is responsible for launching the simple ksysguard module > that krunner used to show when pressing the "Ctrl + Escape" keyboard > shortcut. > > Most of this code used to exist in the old krunner > > > Diffs > ----- > > CMakeLists.txt 8834986 > ksysguard/CMakeLists.txt PRE-CREATION > ksysguard/kded_ksysguard.desktop PRE-CREATION > ksysguard/kdedksysguard.h PRE-CREATION > ksysguard/kdedksysguard.cpp PRE-CREATION > ksysguard/ksystemactivitydialog.h PRE-CREATION > ksysguard/ksystemactivitydialog.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117374/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
