> On April 30, 2014, 12:30 p.m., David Edmundson wrote: > > src/declarativeimports/core/windowthumbnail.cpp, line 317 > > <https://git.reviewboard.kde.org/r/117824/diff/2/?file=269508#file269508line317> > > > > Do you still need this after the change above? > > > > I'm all for safety guards, but not if it's unneeded code. > > > > Maybe add a debug and see if it comes up IRL.
yep, it's still needed. I added an assert (Q_ASSERT(m_glxPixmap == XCB_PIXMAP_NONE)) to see whether the code path is still hit and got an abort in that condition using the steps to reproduce the crashy situation. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117824/#review56961 ----------------------------------------------------------- On April 30, 2014, 7:44 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117824/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 7:44 a.m.) > > > Review request for Plasma and Alexander Richardson. > > > Bugs: 333482 > http://bugs.kde.org/show_bug.cgi?id=333482 > > > Repository: plasma-framework > > > Description > ------- > > Discard window thumbnail pixmap after texture got destroyed by SceneGraph > > If the window holding the WindowThumbnail item goes away the texture hold > by the node is destroyed but our bound window pixmap is not yet freed. > This results in incorrect state the next time the WindowThumbnail is > shown. > > To get back into a clean state discardPixmap() is called if there is no > texture but a bound low level pixmap. > > BUG: 333482 > > > Diffs > ----- > > src/declarativeimports/core/windowthumbnail.cpp > d1a7fef1fc5fd119592710d80274d2abe0c8b3b1 > > Diff: https://git.reviewboard.kde.org/r/117824/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
