----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117891/#review56950 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On April 30, 2014, 6:37 a.m., Eike Hein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117891/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 6:37 a.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: kdeclarative > > > Description > ------- > > DeclarativeDragDropEvent runs the coordinates it gets from > QQuickItem::dragMoveEvent through mapFromScene(), which is unnecessary - the > coordinates are already in the item's reference frame - and actually causes > them to be wrong when a DeclarativeDropArea isn't at QPoint(0,0) in the scene. > > > Diffs > ----- > > src/qmlcontrols/draganddrop/DeclarativeDragDropEvent.cpp 374a09b > > Diff: https://git.reviewboard.kde.org/r/117891/diff/ > > > Testing > ------- > > > Thanks, > > Eike Hein > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
