> On April 24, 2014, 9:33 a.m., Sebastian Kügler wrote:
> > Screenshots?
> >
> > My main question is: Is this going to fit into the new systemtray? The
> > popup is not resizable, so it might push out part of the UI underneath.
>
> Kai Uwe Broulik wrote:
> ... which is really unfortunate.
>
> However, I will drop the Serial number thing as well as
> manufacturer/model if it's already clear from the displayed battery name, ie.
> There's no point in displaying "Logitech Trackball, manufacturer: Logitech".
>
> Sebastian Kügler wrote:
> That's a regression, which will be fixed later. Just pushing in new
> things that will make it appear more broken is not smart.
>
> I'd rather exclude the extra information, in fact I'd rather not make the
> thing expandable at all -- i.e. remove the information. I've this slight
> suspicion that you don't like this suggestion, though. ;)
>
> Kai Uwe Broulik wrote:
> Actually, I was thinking of it myself :-)
>
> Would a tooltip work? I think the capacity is a rather interesting piece
> of information ("oh my battery lasts only half an hour why is that?"). For
> the other things not so much.
>
> Oh and speaking of improving the battery monitor: I do get two icons
> (battery+mouse) cramped into the square space of a single icon in systray as
> iirc there are no means of checking if the battery monitor is constrained in
> a panel or at least it's broken(?)
>
> Kai Uwe Broulik wrote:
> ... or we could create a nifty battery list in Powerdevil settings
> similar to what Gnome [1] provides, put the advanced stuff there and make
> battery monitor super slick.
>
> [1] http://julien.danjou.info/media/images/gnome-power-statistics-k750.png
>
> Sebastian Kügler wrote:
> I like that idea of details is in systemsettings. A lot.
>
> As to battery in systray: these are square for now, and that's not
> something we can reasonably change in time for the first release. I think
> we'll need to rethink this later on.
>
> Kai Uwe Broulik wrote:
> I'm not arguing about the fact it's square but that I cannot detect that
> it's supposed to just show one icon. In Plasma 1 it was something like
> formfactor == horizontal || formfactor == vertical which doesn't seem to work
> with new systray
> In Plasma 1 it was something like formfactor == horizontal || formfactor ==
> vertical which doesn't seem to work with new systray
Nevermind, I just had commented it. Works now.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117542/#review56354
-----------------------------------------------------------
On April 13, 2014, 1:45 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117542/
> -----------------------------------------------------------
>
> (Updated April 13, 2014, 1:45 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This adds the following improvements provided by Review 117339 and Review
> 117540:
> - Show temperature, voltage, energy rate and serial number. Since those are
> only shown when expanding the battery it's imho not that bad to show some
> geeky stuff which can give you some more indication of battery health and
> overall power consumption. It adds new strings, however. It also changes the
> substr hackery to "enabled: false" for greying out the labels.
>
> What's the preferred way of formatting numbers (decimal points, units)? The
> formats thing only seems to be for file sizes and durations.
>
>
> Diffs
> -----
>
> applets/batterymonitor/contents/code/logic.js 5b4cb52
> applets/batterymonitor/contents/ui/BatteryItem.qml 431aa9a
> applets/batterymonitor/contents/ui/CompactRepresentation.qml 39cd331
> applets/batterymonitor/contents/ui/DetailsLabel.qml d973d22
> applets/batterymonitor/contents/ui/PopupDialog.qml 0444199
> applets/batterymonitor/contents/ui/batterymonitor.qml 4711c5e
>
> Diff: https://git.reviewboard.kde.org/r/117542/diff/
>
>
> Testing
> -------
>
> Compiles. Information is properly displayed when expanding a battery.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
_______________________________________________
Plasma-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/plasma-devel
