----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116714/#review52657 -----------------------------------------------------------
Ship it! plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt <https://git.reviewboard.kde.org/r/116714/#comment37147> Can't we make the target to export the include directories as well? Either way, ship it. - Aleix Pol Gonzalez On March 11, 2014, 2:12 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116714/ > ----------------------------------------------------------- > > (Updated March 11, 2014, 2:12 p.m.) > > > Review request for Plasma. > > > Repository: kde-workspace > > > Description > ------- > > dbusmenu-qt now provides a dbusmenu-qt5-config.cmake, so it is no longer > necessary to ship a CMake find module for it. The same change has already > been applied to the knotifications repository. > > > Diffs > ----- > > plasma/generic/dataengines/statusnotifieritem/CMakeLists.txt dfbc4be > plasma/generic/dataengines/CMakeLists.txt 187c24f > appmenu/CMakeLists.txt 7e166e7 > cmake/modules/FindDBusMenuQt5.cmake 7d43489 > CMakeLists.txt 271e7d5 > > Diff: https://git.reviewboard.kde.org/r/116714/diff/ > > > Testing > ------- > > Rebuilt kde-workspace, dbusmenu-qt5 is found. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
