----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114493/#review45760 -----------------------------------------------------------
plasmate/CMakeLists.txt <http://git.reviewboard.kde.org/r/114493/#comment32689> ki18n_wrap_ui or somesuch? plasmate/CMakeLists.txt <http://git.reviewboard.kde.org/r/114493/#comment32690> the webkit include shouldn't be necessary here, but done by the buildsystem plasmate/CMakeLists.txt <http://git.reviewboard.kde.org/r/114493/#comment32691> Please go over the variable names here, and make them use the correct KF5:: names plasmate/CMakeLists.txt <http://git.reviewboard.kde.org/r/114493/#comment32692> ki18n_wrap_ui plasmate/CMakeLists.txt <http://git.reviewboard.kde.org/r/114493/#comment32693> add_executable is fine here I've noted a few things, but noticed something else (actually, bshah did): Is the patch generated correctly? It ports some occurrences of add_executable to kde4_add_executable, which is exactly the wrong way around? - Sebastian Kügler On Dec. 16, 2013, 9:21 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114493/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 9:21 a.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > This is a merge request for plasmoidviewer2 branch into the frameworks branch. > > Plasmoidviewer2 branch contains some missing features and bug fixes. > > > Diffs > ----- > > CMakeLists.txt 2d6219a > engineexplorer/CMakeLists.txt ce0dd6a > engineexplorer/engineexplorer.cpp 1f1b868 > engineexplorer/serviceviewer.cpp 924e4c9 > plasmate/CMakeLists.txt 55e7453 > plasmate/docbrowser/docbrowser.h dc91936 > plasmate/docbrowser/docbrowser.cpp d14eea1 > plasmate/editors/editpage.h 56a1982 > plasmate/editors/editpage.cpp d260585 > plasmate/editors/imageviewer/imageloader.h aafaed0 > plasmate/editors/imageviewer/imageloader.cpp f45ca74 > plasmate/editors/imageviewer/imageviewer.h 2bfbaa5 > plasmate/editors/imageviewer/imageviewer.cpp d9f9d43 > plasmate/editors/kconfigxt/kconfigxteditor.h 0043051 > plasmate/editors/kconfigxt/kconfigxteditor.cpp 13598b7 > plasmate/editors/kconfigxt/kconfigxteditor.ui 5483351 > plasmate/editors/kconfigxt/kconfigxtreader.cpp 9d6346c > plasmate/editors/kconfigxt/kconfigxtwriter.cpp 9bda29d > plasmate/editors/kconfigxt/standalone/main.cpp 8fb83ee > plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp a7e8294 > plasmate/editors/metadata/CMakeLists.txt 602aca9 > plasmate/editors/metadata/metadataeditor.cpp a8a744a > plasmate/editors/metadata/tests/test_metadata.cpp fd8ad93 > plasmate/editors/svg/CMakeLists.txt 0214310 > plasmate/editors/svg/svgviewer.cpp 469b3ff > plasmate/editors/svg/tests/test_svg.cpp bc725ab > plasmate/konsole/konsolepreviewer.cpp e7b38e2 > plasmate/main.cpp 3de6fa8 > plasmate/mainwindow.h 844ef60 > plasmate/mainwindow.cpp 890ad56 > plasmate/modeltest/dynamictreemodel.h 4ba4a8e > plasmate/modeltest/dynamictreemodel.cpp b2f23ea > plasmate/modeltest/modeltest.h b347221 > plasmate/modeltest/modeltest.cpp cf21835 > plasmate/packagemodel.h 4c546c5 > plasmate/packagemodel.cpp dc3e42f > plasmate/previewer/plasmoid/CMakeLists.txt b75bb41 > plasmate/previewer/plasmoid/previewcontainment.h 43de4b8 > plasmate/previewer/plasmoid/previewcontainment.cpp 4449ce7 > plasmate/previewer/plasmoid/test/CMakeLists.txt 4e8649a > plasmate/previewer/plasmoid/test/main.cpp 6a30bdd > plasmate/previewer/windowswitcher/standalone/main.cpp b30d57a > plasmate/previewer/windowswitcher/standalone/windowswitcherpreviewer.h > 3a43af8 > plasmate/previewer/windowswitcher/standalone/windowswitcherpreviewer.cpp > 55d0d8a > plasmate/previewer/windowswitcher/tabboxpreviewer.cpp 2606582 > plasmate/previewer/windowswitcher/thumbnailitem.h 2721044 > plasmate/previewer/windowswitcher/thumbnailitem.cpp 6d03078 > plasmate/previewer/windowswitcher/windowswitcher.h c5c3d13 > plasmate/previewer/windowswitcher/windowswitcher.cpp 6d544a5 > plasmate/projectmanager/projectmanager.h 645dffe > plasmate/projectmanager/projectmanager.cpp e291ed1 > plasmate/publisher/publisher.h 92e80cd > plasmate/publisher/publisher.cpp 529bd2e > plasmate/publisher/publisher.ui a149949 > plasmate/publisher/remoteinstaller/remoteinstaller.h efb28fe > plasmate/publisher/remoteinstaller/remoteinstaller.cpp 5f4de97 > plasmate/publisher/remoteinstaller/remoteinstaller.ui 67d868f > plasmate/publisher/remoteinstaller/remoteinstallerdialog.h 7317eaf > plasmate/publisher/remoteinstaller/remoteinstallerdialog.cpp 3b41b33 > plasmate/publisher/remoteinstaller/standalone/main.cpp c82e4b2 > plasmate/publisher/signingwidget.h 939d1d8 > plasmate/publisher/signingwidget.cpp 3b65544 > plasmate/savesystem/commitdialog.h c41836b > plasmate/savesystem/commitdialog.cpp 9a6ecc3 > plasmate/savesystem/dvcsjob.h 77838ec > plasmate/savesystem/dvcsjob.cpp bd88b24 > plasmate/savesystem/gitrunner.h 3171b82 > plasmate/savesystem/gitrunner.cpp 9b4a03e > plasmate/savesystem/test/CMakeLists.txt 706c330 > plasmate/savesystem/test/main.cpp aa987c3 > plasmate/savesystem/timeline.h b58a72d > plasmate/savesystem/timeline.cpp f4454fd > plasmate/sidebartablewidget.cpp c9980e1 > plasmate/startpage.h d466fa7 > plasmate/startpage.cpp a1d707a > plasmate/startpage.ui c0c232a > plasmate/test-kpart/CMakeLists.txt 761afcd > plasmate/test-kpart/main.cpp 9d67674 > plasmate/test-kpart/mainwindow.h ea517b3 > plasmate/test-kpart/mainwindow.cpp a18a66a > plasmoidviewer/CMakeLists.txt 30de8e2 > plasmoidviewer/fullview.h 7d4c70d > plasmoidviewer/fullview.cpp 898931a > plasmoidviewer/main.cpp f3cdb22 > plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60 > plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js > 62e149a > plasmoidviewer/qmlpackages/containment/contents/config/main.xml d889999 > plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml > b23e098 > plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0 > plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710 > plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217 > plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3 > plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION > plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION > plasmoidviewer/view.h 0e2e48c > plasmoidviewer/view.cpp fc008b0 > > Diff: http://git.reviewboard.kde.org/r/114493/diff/ > > > Testing > ------- > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
